ramitkataria commented on code in PR #55088:
URL: https://github.com/apache/airflow/pull/55088#discussion_r2335044457
##########
providers/edge3/src/airflow/providers/edge3/plugins/www/__init__.py:
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
It looks like this file was created accidentally?
##########
airflow-core/tests/unit/models/test_deadline.py:
##########
@@ -371,11 +373,25 @@ def test_deadline_database_integration(self, reference,
expected_column, session
if expected_column is not None:
result = reference.evaluate_with(session=session,
interval=interval, **conditions)
mock_fetch.assert_called_once_with(expected_column,
session=session, **conditions)
+ elif reference == DeadlineReference.AVERAGE_RUNTIME:
+ with mock.patch("airflow._shared.timezones.timezone.utcnow")
as mock_utcnow:
+ mock_utcnow.return_value = DEFAULT_DATE
+ with mock.patch.object(session, "execute") as mock_execute:
Review Comment:
It looks like this a DB test so I'm not sure if we should be mocking
session.execute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]