eladkal commented on code in PR #55179:
URL: https://github.com/apache/airflow/pull/55179#discussion_r2339710952
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/msgraph.py:
##########
@@ -250,7 +250,9 @@ def to_msal_proxies(self, authority: str | None, proxies:
dict) -> dict | None:
def _build_request_adapter(self, connection) -> tuple[str, RequestAdapter]:
client_id = connection.login
client_secret = connection.password
- config = connection.extra_dejson if connection.extra else {}
+ # TODO: do not use connection.extra_dejson until it's fixed in Airflow
otherwise expect:
Review Comment:
I think the goal is not to have todos.
The TODO is not so clear to me. Please explain what specifically is missing.
The issue you linked to is about msgraph while you are refering to a problem in
airflow core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
