jason810496 commented on code in PR #54813:
URL: https://github.com/apache/airflow/pull/54813#discussion_r2329847364
##########
airflow-core/src/airflow/logging/remote.py:
##########
@@ -44,6 +44,15 @@ def upload(self, path: os.PathLike | str, ti: RuntimeTI) ->
None:
"""Upload the given log path to the remote storage."""
...
- def read(self, relative_path: str, ti: RuntimeTI) -> tuple[LogSourceInfo,
LogMessages | None]:
+ def read(self, relative_path: str, ti: RuntimeTI) -> LegacyLogResponse:
"""Read logs from the given remote log path."""
...
+
+
+@runtime_checkable
+class RemoteLogStreamIO(Protocol):
Review Comment:
Either option works for me, but I’ll wait for your suggestion, Ash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
