ArthurKretzer opened a new pull request, #55457:
URL: https://github.com/apache/airflow/pull/55457
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
---
closes: [#ISSUE](https://github.com/apache/airflow/issues/55433)
## Summary
This PR fixes a bug in the `WeaviateHook` where the `port` specified in the
Airflow connection is ignored for non-HTTPS configurations, causing the hook to
always default to port 80.
The root cause is an operator precedence issue in the `http_port`
assignment. This change corrects the logic by adding parentheses to ensure the
ternary operator is evaluated correctly, thus respecting the user-configured
port.
### Proposed Change
The logic in `airflow/providers/weaviate/hooks/weaviate.py` is corrected as
follows:
- **Before:**
```python
http_port=conn.port or 443 if http_secure else 80,
```
- **After:**
```python
http_port=conn.port or (443 if http_secure else 80),
```
### Tests
- [x] Existing unit tests for the Weaviate provider were executed and
continue to pass.
- This change is a direct logical fix, and a new test case could be added
to specifically cover custom ports on non-HTTPS connections to prevent future
regressions.
### Documentation
- [x] No documentation changes are required. This PR aligns the hook's
behavior with the expected and documented functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
