Hi Arthur,

I read a little bit further. Indeed the application_setting is used for setting 
cookies and it isn’t used for changing the base_url. However, a WSGI 
application (like Airflow) works with mount points to the webserver. This 
requires a middle-ware configuration which is explained in the stackoverflow 
lemma a bit more down. I think this is the right approach.

As the Rest API is connected to the webserver at the moment,I do think it is 
also correct to move the API endpoints indeed. If we think this should be 
managed independently it should be mounted separately.

Cheers
Bolke

> On 14 Jan 2018, at 00:02, Arthur Wiedmer <arthur.wied...@gmail.com> wrote:
> 
> Bolke,
> 
> Wouldn't application_root cause an issue with cookies (
> https://stackoverflow.com/questions/18967441/add-a-prefix-to-all-flask-routes)
> since Gaetan did not want to move the API endpoint, or do you recommend the
> API endpoint to be moved as well in this scenario?
> 
> Best,
> Arthur
> 
> On Sat, Jan 13, 2018 at 10:59 AM, Bolke de Bruin <bdbr...@gmail.com> wrote:
> 
>> I reviewed it and I think some changes are required. Flask provides for an
>> application root (https://stackoverflow.com/questions/34849257/define-url-
>> root-with-flask) and cascades too all, which makes a lot of the changes
>> redundant and simpler.
>> 
>> Also tests are missing. Some other comments on the PR.
>> 
>> Cheers
>> Bolke
>> 
>>> On 6 Jan 2018, at 10:46, Gaetan Semet <gae...@xeberon.net> wrote:
>>> 
>>> Hello
>>> 
>>> Can a core developer look at my pull request ?
>>> https://github.com/apache/incubator-airflow/pull/2723
>>> 
>>> Thanks
>>> Gaetan
>>> 
>>> On 2017-12-10 14:37, Sergei Iakhnin <lle...@gmail.com> wrote:
>>>> This feature sounds very useful. I hope you get your PR in soon.
>>>> 
>>>> On Sat, Dec 9, 2017 at 7:59 PM Gaetan Semet <gae...@xeberon.net> wrote:
>>>> 
>>>>> Hello
>>>>> 
>>>>> Sorry to insist on my PR review, but it seems it can help some people:
>>>>> https://github.com/apache/incubator-airflow/pull/2723#
>> issuecomment-350356492
>>>>> 
>>>>> For recall, this allows to easily set up airflow as url such as
>>>>> 
>>>>> https://lab.mycompany.com/myorg/airflow/
>>>>> 
>>>>> and flower in
>>>>> 
>>>>> https://lab.mycompany.com/myorg/airflow/flower
>>>>> 
>>>>> API will be accessible at
>>>>> 
>>>>> https://lab.mycompany.com/myorg/airflow/api/experimental/...
>>>>> 
>>>>> Thanks
>>>>> 
>>>>> Gaetan Semet
>>>>> 
>>>> --
>>>> 
>>>> Sergei
>>>> 
>> 
>> 

Reply via email to