Hi all, I've did some more tests and it looks good. I was under the assumption that the sequential executor runs within the webserver, but this was a wrong assumption on my end. The behaviour is still the same as in 1.9. I've did some tests on Python 2.7, 3.5 and 3.6 and it looks good. Python 3.7 does not work yet, but it isn't supported anyway.
I would like to have https://github.com/apache/incubator-airflow/pull/3604 in RC2. It isn't a critical bug, but it looks messy. Cheers, Fokko 2018-07-14 0:06 GMT+02:00 Driesprong, Fokko <fo...@driesprong.frl>: > Thanks Bolke for all the effort. > > I think I've miscommunicated the issue. It doesn't schedule the runs, and > when I explicitly kick of a run, it also isn't being picked up. > > Currently I'm doing a git bisect to check when this bug was introduced > happend. To be continued. > > Cheers, Fokko > > 2018-07-13 23:28 GMT+02:00 Bolke de Bruin <bdbr...@gmail.com>: > >> Hi Fokko, >> >> Please confirm this, because I tried sequential with a clean install. The >> only thing I found was that example DAGs were not picked up. >> >> I’m rolling rc2 anyway though so it would be good to get it fixed. >> >> B. >> >> Verstuurd vanaf mijn iPad >> >> > Op 13 jul. 2018 om 22:23 heeft Driesprong, Fokko <fo...@driesprong.frl> >> het volgende geschreven: >> > >> > Ok, I've did some testing. >> > >> > 1.10 works fine with the LocalExecutor. With the SequentialExecutor it >> does >> > not pick up any task, even with a different database as sqlite. Found >> this >> > one along the way: https://github.com/apache/incu >> bator-airflow/pull/3604 >> > >> > There are no recent changes to the SequentialExecutor, so I'm still >> looking >> > how this bug found its way into the source. For me this is a -1, right >> now >> > it is not possible to just give Airflow a try using a basic setup with a >> > SequentialExecutor. >> > >> > Along the way this also makes me reconsider the tests. Like with the >> > Kubernetes test we just run a task, and then assert if it ran properly. >> > This might also be an idea for the sequential executor. >> > >> > Cheers, Fokko >> > >> > 2018-07-13 20:15 GMT+02:00 Jakob Homan <jgho...@gmail.com>: >> > >> >> @Bolke - I didn't raise the concern, so I can't speak to whether or >> >> not Sebb will be ok with that. He tends to be pretty fastidious on >> >> this stuff and 'but some other TLP does it' hasn't gone over well >> >> before (trust me... I've tried). Totally up to you if you'd rather >> >> discuss it as part of the IPMC vote or just fix it to avoid >> >> discussion. >> >> >> >> -jakob >> >> >> >> On 13 July 2018 at 09:48, Ash Berlin-Taylor >> >> <ash_airflowl...@firemirror.com> wrote: >> >>> Cloud that be related to my ignorefile change? `airflow list_dags` >> still >> >> shows the example dags - the output is the same for that command as on >> >> v1-9-stable. >> >>> >> >>> Though I just noticed I'd left `self.log.info <http://self.log.info/ >> >()` >> >> in there. That's going to be noisy. https://github.com/apache/ >> >> incubator-airflow/pull/3603 <https://github.com/apache/ >> >> incubator-airflow/pull/3603> >> >>> >> >>> -ash >> >>> >> >>>> On 13 Jul 2018, at 17:36, Bolke de Bruin <bdbr...@gmail.com> wrote: >> >>>> >> >>>> Example dags are not picked up. If you put a dag in the normal dag >> >> folder it works fine. >> >>>> >> >>>> Please create a jira for this @fokko. A pr would be appreciated. >> >>>> >> >>>> B. >> >>>> >> >>>> Sent from my iPhone >> >>>> >> >>>>> On 13 Jul 2018, at 15:46, Driesprong, Fokko <fo...@driesprong.frl> >> >> wrote: >> >>>>> >> >>>>> With the SequentialExecutor the webserver also acts as the scheduler >> >>>>> (without parallelism) >> >>>>> >> >>>>> 2018-07-13 15:43 GMT+02:00 Carl Johan Gustavsson < >> >> carl.jo...@tictail.com>: >> >>>>> >> >>> >> >> >> > >
