I did a quick scan and it looks like great work, thanks for your contribution! I'm guessing the committers are all either busy or vacationing at this moment. Let's make sure this gets properly reviewed and merged.
Related to this is the thought of having a formal flow for improvement proposals so that we can do some design review upfront, and couple contributors with committers early to make sure the process goes through smoothly. It hurts to have to have quality contributions ignored. Clearly we need to onboard more committers to insure quality work gets merged while also providing steady, high quality releases. In the meantime I'd advise you to ping regularly to make sure this PR gets the attention it deserves and prevent it from getting buried in the pile. Max On Tue, Jul 17, 2018 at 5:27 AM James Meickle <jmeic...@quantopian.com.invalid> wrote: > Hi all, > > I'd still love to get some eyes on this one if anyone has time. Definitely > needs some direction as to what is required before merging, since this is a > higher-level API change... > > -James M. > > On Mon, Jul 9, 2018 at 11:58 AM, James Meickle <jmeic...@quantopian.com> > wrote: > > > Hi folks, > > > > Based on my earlier email to the list, I have submitted a PR that splits > > `sla=` into three independent SLA parameters, as well as heavily > > restructuring other parts of the SLA feature: > > > > https://github.com/apache/incubator-airflow/pull/3584 > > > > This is my first Airflow PR and I'm still learning the codebase, so > > there's likely to be flaws with it. But I'm most interested in the > general > > compatibility of this feature with the rest of Airflow. We want this for > > our purposes at Quantopian, but we'd really prefer to get it into Airflow > > core rather than running a fork forever! > > > > Let me know your thoughts, > > > > -James M. > > >
