- **status**: code-review --> in-progress
- **Comment**:
Functionality and location look good now.
For the test, we generally check for short snippets of HTML in the response
(`r` or `r.body` or `r.html`) rather than checking `r.controller_output`. That
helps confirm that the template is doing the proper thing too.
The PEP8 cleanup commit has a few issues, you may want to check your editor
settings or cleanup tool. First, the license text got unindented on the first
lines. Second, my editor and the pep8 tool (shown below) actually complain
about the moved "}" and that it was ok before.
~~~~
$ pep8 --max-line-length=119 Allura/allura/ext/admin/admin_main.py --show-source
...
Allura/allura/ext/admin/admin_main.py:822:13: E124 closing bracket does not
match visual indentation
}
^
...
~~~~
---
** [tickets:#7293] Trove Category Admin Browse**
**Status:** in-progress
**Milestone:** forge-jul-11
**Created:** Wed Mar 26, 2014 02:06 PM UTC by Chris Tsai
**Last Updated:** Mon Jul 07, 2014 10:54 PM UTC
**Owner:** Alexander Luberg
It's hard to figure out what's already in the Trove system (at "/categories/")
without significant prior knowledge of its organization. A search function
would make it much easier.
---
Sent from sourceforge.net because [email protected] is subscribed to
https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
