- **status**: in-progress --> code-review - **Comment**: Closed #633. `je/42cc_7472`
--- ** [tickets:#7472] Thread view counts shouldn't trigger add_artifact tasks** **Status:** code-review **Milestone:** forge-backlog **Labels:** performance 42cc **Created:** Tue Jun 17, 2014 03:25 PM UTC by Dave Brondsema **Last Updated:** Fri Aug 15, 2014 12:26 AM UTC **Owner:** Igor Bondarenko The `ThreadController.index` method increases the view count of the thread. While it does set `skip_mod_date`, it still makes the thread object "dirty" (in the ming odm session), and thus ManagedSessionExtension/ArtifactSessionExtension thinks it is a change needing to be saved into solr, so and `add_artifacts` task runs. That is a lot of unnecessary work generated from a pageview. We shouldn't run the `add_artifacts` task (if not easy to avoid it, perhaps easier to run a mongo `$inc` command and avoid the session). And possibly consider not tracking view counts at all. --- Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
