- **status**: in-progress --> code-review
- **Comment**:
Closed #668. `je/42cc_7679`
I made change in `Project.users_with_role`. It is used only in:
- members & admins wiki macro
- spam check for discussions (to skip check for admins and devs)
- doap and rest API endpoints
- inside `Project.admins`
For all of this it makes sense to filter out disabled users, I think.
It is also used in `forge-classic` to get list of users for a releasers page
(e.g. `/p/project1/admin/files/releasers/`). I assume it's ok to filter out
disabled users there too, since they will not be able to do anything with
releases anyway. But I'm not 100% sure about this, so you may wanna recheck.
~~~~~
ForgeSF/forgesf/model/permissions.py
118: self.project.users_with_role('Admin',
'Developer'))]
~~~~~
Also, I've checked all extensions maintained by us, that listed here
https://forge-allura.apache.org/p/allura/wiki/Extensions/. There are no uses of
`users_with_role` in any of them.
Perhaps, you may want to check sfpy also
---
** [tickets:#7679] project.admins() should not include disabled users**
**Status:** code-review
**Milestone:** forge-oct-17
**Labels:** 42cc
**Created:** Thu Sep 11, 2014 02:52 PM UTC by Dave Brondsema
**Last Updated:** Tue Oct 07, 2014 06:42 AM UTC
**Owner:** Igor Bondarenko
Currently disabled users are included in `project.admins()` method but they
shouldn't be. This shows up in the project details above the nav bar, and in
the DOAP output.
Perhaps the change should happen in `users_with_role` so that all those calls
have disabled users filtered out too. Need to check all the `users_with_role`
calls to make sure that makes sense.
---
Sent from sourceforge.net because [email protected] is subscribed to
https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
