- **QA**: Dave Brondsema
- **Comment**:

Can you comment (here or in the code) about what the change in 
`ForgeMacroPattern` really does?  The inline comment seems to be about the 
`strip()` and `join()` but it's not obvious to me what calling 
`etree.fromstring()` does in this context.

The custom `slugify` function took me a bit to get (maybe just because its a 
friday afternoon) but looks like its the same as the original but with better 
unicode handling.



---

** [tickets:#4771] TOC macro doesn't add headers of included pages [ss246]**

**Status:** code-review
**Milestone:** forge-oct-17
**Labels:** support p3 42cc 
**Created:** Thu Aug 23, 2012 12:41 PM UTC by Chris Tsai
**Last Updated:** Mon Oct 06, 2014 02:30 PM UTC
**Owner:** Igor Bondarenko

[forge:site-support:#246]

>On the page above there is a table of contents just underneath the Versions 
>Heading, and then each of the headings after that are included from seperate 
>pages per version. I would expect that the table of contents to display the 
>headings from the included pages as well as the headings from the current 
>page. This does not happen.

>It may just be me not quite understanding it, however it would be nice to have

I've put together a page demonstrating this here: 
https://sourceforge.net/p/strawhat/wiki/top/


---

Sent from sourceforge.net because [email protected] is subscribed to 
https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to