Closed #723. Updated `ib/4542` with the following:

- Tweak error message
- Change repo-push hook payload

Created #726 for the following:

- Add separate 'edit' link for webhook edit
- Fix table width when webhook link is long
- Move 'Webhooks' from sidebar to app admin
- Remove or document MingOneOf
- Fix message: "You have exceeded the maximum number of projects" should say 
"... of webhooks"

Tested with Slack (GitHub with manual configuration), Flowdock (the same) and 
HipChat (Google Code API hook url).

Slack works.

Flowdock: submit successful, but nothing shows up. It requires to configure 
GitHub hook as "send everything", so I guess it checks `X-GitHub-Event` header 
to distinguish between events, and we do not provide that. And if I add this 
header, webhook submit fails with:

~~~~~
09:57:21,258 ERROR 
[taskd:allura.webhooks.send_webhook:54db278004687d34e52600ef:allura.webhooks] 
Webhook send error: repo-push 
https://www.flowdock.com/jari/github/messages/bd36bad4407ee69c9145df34ce9c5856?tag=9af05261-97dd-47d3-8303-5f2721562ac9&jari=778fcd79e9ffdc6594d8331a7ea85189
 /p/test/git/ 500 {"message":"Internal server error"} 
CaseInsensitiveDict({'status': '500 Internal Server Error', 'x-request-id': 
'160bbd50-5aca-4d9a-acc9-1013d17b1724', 'x-xss-protection': '1; mode=block', 
'x-content-type-options': 'nosniff', 'content-encoding': 'gzip', 'x-server-id': 
'45c836f72727be03bd8c2ae92cedbf6a75a556bc', 'vary': 'Accept-Encoding', 
'content-length': '55', 'x-runtime': '0.039335', 'date': 'Wed, 11 Feb 2015 
09:57:21 GMT', 'x-frame-options': 'SAMEORIGIN', 'content-type': 
'application/json; charset=utf-8'})
~~~~~

.

HipChat: webhook submit fails due to incompatible payload format:

~~~~~
10:16:08,659 ERROR 
[taskd:allura.webhooks.send_webhook:54db2be604687d449b51b8b3:allura.webhooks] 
Webhook send error: repo-push 
https://api.hipchat.com/v1/webhooks/googlecode/?auth_token=155a45b4e6176b2c06e51c333b4658&room_id=1215273
 /p/test/git/ 400 {"error":{"code":400,"type":"Bad Request","message":"Bad POST 
data format"}} CaseInsensitiveDict({'x-ratelimit-remaining': '99', 
'content-length': '76', 'server': 'nginx', 'x-hipchat-jobs': 'Want to help make 
HipChat better? Apply at hipchat.com/jobs and mention this header.', 
'connection': 'keep-alive', 'x-ratelimit-limit': '100', 'date': 'Wed, 11 Feb 
2015 10:16:08 GMT', 'content-type': 'application/json', 'x-ratelimit-reset': 
'1423649820'})
~~~~~


---

** [tickets:#4542] Implement webhooks**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-8 42cc 
**Created:** Fri Jul 13, 2012 02:55 PM UTC by Dave Brondsema
**Last Updated:** Tue Feb 10, 2015 11:25 PM UTC
**Owner:** Igor Bondarenko

We should have webhooks, compatible with github & bitbucket.  I don't see a 
spec for SCM webhooks anywhere.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to