- **Comment**:
I think this is finally done :)
However I got new test failure
~~~~
======================================================================
FAIL:
forgegit.tests.functional.test_controllers.TestFork.test_merge_request_detail_view
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/local/env-allura/lib/python2.7/site-packages/nose-1.3.4-py2.7.egg/nose/case.py",
line 197, in runTest
self.test(*self.arg)
File
"/home/ibondarenko/ibondarenko-1154/forge/ForgeGit/forgegit/tests/functional/test_controllers.py",
line 599, in test_merge_request_detail_view
assert_equal(rev_links[0].get('href'), '/p/test2/code/ci/%s/' % c_id)
AssertionError: u'/p/test2/code/ci/5f781900aac5e36cc9a48228df2e5c125d8a9765/'
!= '/p/test2/code/ci/1e146e67985dcd71c74de79613719bef7bddca4a/'
-------------------- >> begin captured stdout << ---------------------
~~~~
Is caching enabled in tests? I suggest we disable it in tests by default and
enable only whenever needed.
Other than that looks/works good.
Regarding configtree, I meant we should made changes to the "configtree" repo
(`/var/local/configtree` on a sandbox). I've made the changed and pushed them
to `ib/7873` already, so don't worry about that.
AFAIK yes, we should add "NEEDS CONFIGTREE" to the ticket description after we
close the ticket, so that it will be immediately visible that ticket requires
configuration changes. It helps when we organize notes for the release and also
for siteops, I guess.
You can got ahead and merge this (both allura and configtree), whenever test is
fixed.
---
** [tickets:#7873] Git branch & tag speedups**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** performance sf-current sf-4
**Created:** Fri Apr 17, 2015 09:23 PM UTC by Dave Brondsema
**Last Updated:** Tue Jun 16, 2015 06:28 PM UTC
**Owner:** Heith Seewald
I saw that git pages on forge-allura.apache.org were slow, so I looked at
stats.log and saw that the sidebar was the slowest part. I did some additional
digging and found 2 specific areas for improvement:
* in `git_main.py` change `default_branch_name` to a `@LazyProperty` since it
is called many times inside a loop in `RepositoryApp.sidebar_menu`
* Since `sidebar_menu` only requests a certain number of branches, pass that
"limit" all the way through to `git_repo.py`'s `branches` method so that
`is_valid()` is only called a minimum number of times needed.
* make sure the default branch logic to put it at the top of the list still
works (e.g. always put it at the top first)
In addition to those changes, generalize and apply the same approach to the
tags. And also check ForgeHg to see if mercurial can benefit the same way.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
