Looking at what you've pushed so far, here's some feedback on the code:
* json_nav output is a little bit backwards-incompatible. The top-level list
used to be "menu" and now it is "children". Would be nice to keep that
unchanged, but if its better to be "children" for some reason, then users of
`_nav.json` will have to accomodate.
* in `def mount_order` using `except AttributeError` seems to be a pretty rough
way to know if its a subproject. Other things could potentially cause an
AttributeError too. Is there a more precise way?
* tests for the new admin API endpoints would be good
* in `AppConfig.__json__` you moved a line with `_deinstrument` in it, but left
the comment about that behind
* need license headers on `navbar.css` and `navbar.es6.js`
* need to add other JS lib filenames to `rat-excludes.txt` and confirm they are
BSD/MIT/Apache licensed
And UI items. (I know there's still a lot in progress)
* When editing, should we show the tool label, so its more like the non-edit
view? I think so. I got confused when I didn't see my tool names :)
* anchored tools should not be draggable
* I do see a little delay before the menu pops in (when not running everything
locally, so some network latency). And I'm sure other people could have more
network latency or slower machines.
* Plus there will be some people that want to use the site with JS off,
which we don't really support. But the nav menu is a pretty core feature.
* So I am thinking we should at some point before we're done, figure out a
way to show the plain HTML menu at first, and then swap the JSX menu in when
its ready.
---
** [tickets:#7919] Create backend for new admin toolbar**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** new-admin sf-4 sf-current
**Created:** Fri Jul 10, 2015 07:20 PM UTC by Heith Seewald
**Last Updated:** Wed Aug 05, 2015 03:02 PM UTC
**Owner:** Heith Seewald
We need api endpoints for getting and setting:
- Tool ordering
- Tool grouping
- Tool options
- Ability to rename or remove a tool
There are some endpoints that already exist that can be referenced (like
`update_mount_order`).
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
