- **status**: review --> in-progress
- **Reviewer**: Dave Brondsema
- **Comment**:
This is great. Some thoughts to polish it up even more:
* In `def attach`, not doing the redirect when AJAX is good. Can you do that
when deleting an attachment too?
* Using `onsubmit` attributes in HTML isn't the best way to set up JS event
handlers. Could you change it to jquery's `.on('submit')`? That will also
mean you don't need to pass onsubmit strings through the templates. Just have
an appropriate selector to find the form for the `.on` call.
---
** [tickets:#7998] Adding attachment to wiki loses your text changes**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** ux 42cc sf-current sf-2
**Created:** Mon Oct 05, 2015 02:17 PM UTC by Dave Brondsema
**Last Updated:** Wed Dec 23, 2015 02:34 PM UTC
**Owner:** Igor Bondarenko
When editing a wiki page and adding or removing an attachment, any changes you
may have made to the wiki text get lost.
I'd suggest we make the add & delete attachments into ajax calls. (Another
option would be submit the wiki text form too and controller would handle both
types of changes at once). Ajax would be a nice direction towards someday
allowing drag/drop of images into a markdown editor and auto-attach and insert
`[[img src=...]]` for you.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
