- **status**: review --> in-progress
- **Comment**:

The new `reject` method has several lines that are the same as the `save` 
method.  It'd be better to share the same method, so there's not repeated code. 
 Can you change the `save` method to incorporate the additional permission 
checking, and have the form submit there?

The added `get_creator()` method looks the same as the `.creator` property 
defined right above it.  Can you use `.creator` instead?

The reject button is right up against the sidebar.  Can you put a `<div 
class="grid-19">` around it like the Merge button has?  Then it should have 
some spacing.

Thanks




---

** [tickets:#8029] Submitter should be able to reject merge request**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** merge-requests 
**Created:** Tue Dec 08, 2015 03:31 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 11, 2016 06:58 PM UTC
**Owner:** Pranav Sharma


The submitter of a merge request should be able to change its status to 
"rejected" (or possibly delete it, but I think that'd be going too far).  
[#5993] for updating an existing request will help too, but there's still a 
good case for rejecting your own MR I think.

This has been requested by several SF users: 
https://sourceforge.net/p/forge/feature-requests/254/


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to