- **status**: review --> in-progress - **Reviewer**: Dave Brondsema - **Comment**:
Hi Denis, This is looking pretty good, but some small improvements can be made: * It'd be useful to have an optional parameter for "url" so that the URL regex logic can take effect. * Other APIs also work without oauth, if you are currently logged in. That's quite convenient. It works because they use `c.user`. Can we set this one up the same way? By the way, it is nice for more "core" methods, e.g. `_get_site_notification` to have things like `user` passed in instead of using the globals. So don't change that, just pass `c.api_token.user` / `c.user` in as an argument. * I think that can also help clean up the two `_get_site_notification` calls which are very similar. It'd be nicer if it could be just one call (always passing in some user object). * In the `.raml` can you move the new section to the very end? It's not as important as the all the other tools, so better to have it show up last instead of first. --- ** [tickets:#8044] API for current site notification** **Status:** in-progress **Milestone:** unreleased **Labels:** api sf-current sf-2 42cc **Created:** Wed Jan 13, 2016 03:35 PM UTC by Dave Brondsema **Last Updated:** Fri Jan 22, 2016 12:04 PM UTC **Owner:** Igor Bondarenko Expose the current site notification (i.e. `ThemeProvider.get_site_notification` logic) as an API. The `request.cookies` might be able to stay as it is, but likely should support those values being passed in as regular API params. The `response.set_cookie` probably should be returned as response values. Make sure the RAML api docs are updated. --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
