Great feedback -- I'll respond to one at a time and go from there.
> Can we have a separate .eslintrc for ES5 files?
Yes -- we should be able to do something like the following inside our
package.json:
~~~~json
"scripts": {
...
"eslint": "eslint",
"lint-es5": "eslint -c .eslintrc-es5 --ignore-path .eslintignore-es5
Allura/allura/public/**/*.es6.js || true",
"lint-es6": "eslint -c .eslintrc-es6 --ignore-path .eslintignore-es6
Allura/allura/public/**/*.js || true",
"lint": "npm run lint-es6 && npm run lint-es5"
},
~~~~
Or if `test_static_controller` expects a regular .eslintrc file -- then we can
use that naming convention for the es5 (or adjust the test).
What do you think?
---
** [tickets:#8035] Finalize frontend eslint/jscs setup**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Mon Dec 14, 2015 03:48 PM UTC by Heith Seewald
**Last Updated:** Mon Jan 25, 2016 06:27 PM UTC
**Owner:** Heith Seewald
**Attachments:**
-
[.eslintrc](https://forge-allura.apache.org/p/allura/tickets/8035/attachment/.eslintrc)
(416 Bytes; application/octet-stream)
-
[.jscsrc](https://forge-allura.apache.org/p/allura/tickets/8035/attachment/.jscsrc)
(169 Bytes; application/octet-stream)
Finalize and cleanup our eslint/jscsrc setup.
This can be a working standard that evolves over time -- but we should get
something in place now so that we can start collecting feedback.
*(Dave has a few tweaked config files attached - they need more work though)*
Then apply these styles to [#7919].
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
