roadan commented on a change in pull request #42: Amaterasu 8
URL: https://github.com/apache/incubator-amaterasu/pull/42#discussion_r257857450
##########
File path:
common/src/main/scala/org/apache/amaterasu/common/execution/actions/Notifier.scala
##########
@@ -14,43 +14,43 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.amaterasu.common.execution.actions
-
-import com.fasterxml.jackson.annotation.JsonProperty
-import
org.apache.amaterasu.common.execution.actions.NotificationLevel.NotificationLevel
-import
org.apache.amaterasu.common.execution.actions.NotificationType.NotificationType
-import org.apache.amaterasu.common.logging.Logging
-
-abstract class Notifier extends Logging {
-
- def info(msg: String)
-
- def success(line: String)
-
- def error(line: String, msg: String)
-
-}
-
-
-object NotificationType extends Enumeration {
-
- type NotificationType = Value
- val success: NotificationType.Value = Value("success")
- val error: NotificationType.Value = Value("error")
- val info: NotificationType.Value = Value("info")
-
-}
-
-object NotificationLevel extends Enumeration {
-
- type NotificationLevel = Value
- val execution: NotificationLevel.Value = Value("execution")
- val code: NotificationLevel.Value = Value("code")
- val none: NotificationLevel.Value = Value("none")
-
-}
-
-case class Notification(@JsonProperty("line") line: String,
- @JsonProperty("msg") msg: String,
- @JsonProperty("notType") notType: NotificationType,
- @JsonProperty("notLevel") notLevel: NotificationLevel)
+//package org.apache.amaterasu.common.execution.actions
Review comment:
You are right, it was re-written in kotlin should be deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
