> On Jan. 16, 2014, 4:27 a.m., Sid Wagle wrote: > > ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalance.py > > > > - Why is the kinit logic not abstracted out in the script? A custom > > extension should be able to provide keytab path and principal to a parent > > function call. > > > >
You are right. There are explicit format and kinit calls in several areas. We could define a ExecuteWithKinit() or something similar that does the necessary and calls Execute(). Let me open a separate JIRA for that. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16942/#review32000 ----------------------------------------------------------- On Jan. 16, 2014, 2:11 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16942/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 2:11 a.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-4308 > https://issues.apache.org/jira/browse/AMBARI-4308 > > > Repository: ambari > > > Description > ------- > > See JIRA description. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-agent.ini e663a25 > ambari-agent/pom.xml 3be0a1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 4e32f2a > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql ff2b480 > ambari-server/src/main/resources/custom_actions/ambari_hdfs_rebalance.py > PRE-CREATION > ambari-server/src/main/resources/custom_actions/hdfs_rebalance.py 6426855 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 82a66e1 > > Diff: https://reviews.apache.org/r/16942/diff/ > > > Testing > ------- > > Running org.apache.ambari.server.controller.AmbariManagementControllerTest > Tests run: 101, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 122.337 sec > > Results : > > Tests run: 101, Failures: 0, Errors: 0, Skipped: 5 > > > Thanks, > > Sumit Mohanty > >
