-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16989/
-----------------------------------------------------------

Review request for Ambari, Nate Cole, Sumit Mohanty, and Tom Beerbower.


Bugs: AMBARI-4325
    https://issues.apache.org/jira/browse/AMBARI-4325


Repository: ambari


Description
-------

Add service/component dependencies to stack definitions and expose via the 
'/stacks' endpoint.

This includes component cardinality, component dependencies and auto-deploy 
information.

Currently, this dependency logic is hard coded in the UI code.

This patch includes the minimal changes including unit testing.  It doesn't 
include any usage of the new information and doesn't include changes to 
StackExtensionHelper, etc.
These changes will be added in subsequent patches.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/state/AutoDeployInfo.java 
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
7be8fc3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/FLUME/metainfo.xml 
13eba83 
  
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml 
1406f45 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml 
129d0ae 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 
5f587d3 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml 
dc43ab6 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HUE/metainfo.xml 
ba580ca 
  
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/metainfo.xml
 2a91403 
  
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml 
9af461e 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml 
1492cd4 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml 
3f3cff1 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml 
40a04b7 
  
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml 
35a090e 
  
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml
 b92a270 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 547764e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 8f92c09 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/metainfo.xml PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/FLUME/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HUE/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/MAPREDUCE/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml 
PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/16989/diff/


Testing
-------

Manual Functional Tests:
- manually deployed all components via Ambari UI

Unit Tests
- Added unit test coverage
- All unit tests pass


Thanks,

John Speidel

Reply via email to