----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17146/#review32370 -----------------------------------------------------------
Overall changes look good, few notes: - having different test file masks for different locations looks odd. Let's convert filenames to lowercase and compare with test* at all locations - get_parent_path(base, directory_name) function may be simplified with use of os.path.split(path) - let's avoid hardcoding HDP stack at stack_test_executor() - let's use os.path.split(path) at stack_test_executor() instead of if root[-7:] == "scripts" - let's add support of test files starting with underscore (as done at ambari-agent). So if any test file name starts with underscore, then only this test file is executed and other files are skipped. - Dmitro Lisnichenko On Jan. 21, 2014, 2:52 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17146/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 2:52 p.m.) > > > Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko. > > > Bugs: AMBARI-4370 > https://issues.apache.org/jira/browse/AMBARI-4370 > > > Repository: ambari > > > Description > ------- > > Modified unittest.py to run stack tests. All tests must be located in > /stacks/stack_version/component directories. Test files must be with > following names: test_*.py. If test contain some none test directories, we > need to include them in STACK_EXCLUDE and/or SERVICE_EXCLUDE. All tests for > stack-component pair are running in sub-process, to prevent conflicts with > module names. All python tests of ambari-server are passed. Also, as tests > for different components run in separate test run, statistics for every run > accumulated and shown in the end. > > > Diffs > ----- > > ambari-server/pom.xml 02fd326 > ambari-server/src/test/python/unitTests.py 9448bb6 > > Diff: https://reviews.apache.org/r/17146/diff/ > > > Testing > ------- > > Tested ambari-server python tests with already commited components tests. > Example of non successful test run: > ---------------------------------------------------------------------- > Component tests with errors: > stack:2.1.1 service:ZOOKEEPER > stack:2.1.1 service:HBASE > ---------------------------------------------------------------------- > Total run:217 > Total errors:0 > Total failures:3 > Total skipped:0 > ERROR > > > Thanks, > > Eugene Chekanskiy > >
