-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17126/#review32381
-----------------------------------------------------------
Dymitro, the logic to identify and list files and folders should not be in
HostCheckReportFileHandler as this file only writes the host check report.
Look at HostInfo.py - let's debug why the pattern lookup does not work.
# Additional path patterns to find existing directory
DIRNAME_PATTERNS = [
"/tmp/hadoop-", "/tmp/hsperfdata_"
]
- Sumit Mohanty
On Jan. 21, 2014, 1:52 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17126/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2014, 1:52 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
>
>
> Bugs: AMBARI-4354
> https://issues.apache.org/jira/browse/AMBARI-4354
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HostCleanup should also check the following directories (and clean):
>
> /tmp/hadoop-*
>
> For example, if the /tmp/hadoop-nagios directory is present, but it doesn't
> have the right ownership/perms for nagios user, the Hive Metastore Nagios
> alert will occur. I saw this after doing an install on an un-clean machine.
>
> {code}
> Hive Metastore status
> CRIT for about a minute
> CRITICAL: Error accessing Hive Metastore status [Error creating temp dir in
> hadoop.tmp.dir /tmp/hadoop-nagios due to Permission denied]
> {code}
>
> An easy way to reproduce this:
>
> 1) Perform install
> 2) Go to Nagios server machine
> 3) Change perms on /tmp/hadoop-nagios so that the nagios user does not have
> access
> 4) The Nagios alert will fire
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostCheckReportFileHandler.py
> c671584
> ambari-agent/src/test/python/ambari_agent/TestHostCheckReportFileHandler.py
> eb7efb2
>
> Diff: https://reviews.apache.org/r/17126/diff/
>
>
> Testing
> -------
>
> Tested on 1.3.3
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
