-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17706/
-----------------------------------------------------------

Review request for Ambari, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-4517
    https://issues.apache.org/jira/browse/AMBARI-4517


Repository: ambari


Description
-------

Currently a view developer can specify resources for a view. The resource plugs 
into the Ambari API framework and is exposed through a user defined service and 
resource adapter.
There are cases where the view developer may want to expose a resource more 
directly through the service and bypass the framework and resource adapter. 

See https://issues.apache.org/jira/browse/AMBARI-4517 for details.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewExternalSubResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewExternalSubResourceService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java
 96bc863 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
 82f2224 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java 
80651ad 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewExternalSubResourceProvider.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
51fe2b6 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java
 9ea6eb0 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java
 9a275d3 
  
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ResourceConfig.java
 8bc3de1 
  
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
 daac81f 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewExternalSubResourceDefinitionTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewExternalSubResourceServiceTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java
 22a03ad 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
754727d 

Diff: https://reviews.apache.org/r/17706/diff/


Testing
-------

New unit tests added.

Ambari server unit tests pass :

Results :

Tests run: 1394, Failures: 0, Errors: 0, Skipped: 7


Thanks,

Tom Beerbower

Reply via email to