----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18218/#review34708 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 <https://reviews.apache.org/r/18218/#comment64919> Should this contain several checks for hostgroup_defs, as hadoop-services.cfg.j2 does? Without additional checks, it seems possible to reference servicegroups=STORM when it doesn't actually exist. contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php <https://reviews.apache.org/r/18218/#comment64921> Misspelled - Nate Cole On Feb. 18, 2014, 12:08 p.m., Arsen Babych wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18218/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 12:08 p.m.) > > > Review request for Ambari, Mahadev Konar and Nate Cole. > > > Bugs: AMBARI-4714 > https://issues.apache.org/jira/browse/AMBARI-4714 > > > Repository: ambari > > > Description > ------- > > Define and impl alerts for Storm service: > Storm DRPC process (running / not running) > Storm Logviewer process (running / not running) > Storm Nimbus process (running / not running) > Storm UI process (running / not running) > Storm UI (accessible / not accessible) > Storm Percent Supervisors live (need WARN and CRIT thresholds) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java > a57c87b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_aggregate.php > db2a20f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_webui.sh > b23045e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py > 69c7c75 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 > 0101ce6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > 2b3fe1e > ambari-server/src/test/python/stacks/2.1.1/configs/default.json ebb0742 > ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 2631592 > ambari-web/app/models/alert.js e2781d9 > contrib/addons/src/addOns/nagios/scripts/nagios_alerts.php fa68704 > > Diff: https://reviews.apache.org/r/18218/diff/ > > > Testing > ------- > > > Thanks, > > Arsen Babych > >
