----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18451/#review35369 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java <https://reviews.apache.org/r/18451/#comment65846> Generally not done this way for "production" code, as it ends up being a weird anonymous inner class. That's ok for unit tests, but usually isn't deployed that way. Prefer Collections.singletonList(resourceFilter) or Arrays.asList(resourceFilter) - Nate Cole On Feb. 24, 2014, 9:30 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18451/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 9:30 p.m.) > > > Review request for Ambari, Mahadev Konar, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-4791 > https://issues.apache.org/jira/browse/AMBARI-4791 > > > Repository: ambari > > > Description > ------- > > Currently, restarting all components (or all components that need config > update) on a host (or multiple hosts) requires batching of multiple calls > (one call per component type). This results in a whole bunch of requests > being generated and floods the request history visible from the background > operation popup. > Restart should work in a similar way as "Start" and "Stop" for host > components, where the FE can construct a single API call that results in a > single request. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > d1047a7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java > b59eff1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 74aa1fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > ba42cc5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7e7f381 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > b9f62e4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > ae57af2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java > f8dd908 > > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java > 5251b3d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 92d1476 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > 072b4ed > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestResourceFilterEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java > f104259 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2e97b08 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e0e6927 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 60462e2 > ambari-server/src/main/resources/META-INF/persistence.xml c85d79d > ambari-server/src/main/resources/properties.json 270353b > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > d052673 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > dc4c5a5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java > 3f46ce0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > e279342 > > Diff: https://reviews.apache.org/r/18451/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.server.controller.AmbariManagementControllerTest > Tests run: 105, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 135.973 sec > Running > org.apache.ambari.server.controller.internal.RequestResourceProviderTest > Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.838 sec > Running org.apache.ambari.server.controller.MaintenanceStateHelperTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.164 sec > > Results : > > Tests run: 121, Failures: 0, Errors: 0, Skipped: 6 > > > Thanks, > > Sid Wagle > >
