----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18521/#review35541 -----------------------------------------------------------
* In general, the STORM should not be using JMX - I think there's a JIRA for that already (I won't penalize this review for that :) ) * This diff is only addressing /api/cluster/summary from Storm. No others are required? /api/supervisors/summary etc? ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java <https://reviews.apache.org/r/18521/#comment66139> When we refactor (assuming using the HttpProxyPropertyProvider), make that be able to take any type of reader. Also, we want to move to Gson, not Jackson. ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java <https://reviews.apache.org/r/18521/#comment66133> Is it possible to set the port of the STORM_REST_API component using the UI? If so, then this will result in a failed query. - Nate Cole On Feb. 26, 2014, 11:45 a.m., Arsen Babych wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18521/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 11:45 a.m.) > > > Review request for Ambari, Mahadev Konar and Nate Cole. > > > Bugs: AMBARI-4849 > https://issues.apache.org/jira/browse/AMBARI-4849 > > > Repository: ambari > > > Description > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [0.171s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.037s] > [INFO] Ambari Web ........................................ SUCCESS [13.872s] > [INFO] Ambari Views ...................................... SUCCESS [1.446s] > [INFO] Ambari Server ..................................... SUCCESS > [10:37.226s] > [INFO] Ambari Agent ...................................... SUCCESS [11.076s] > [INFO] Ambari Client ..................................... SUCCESS [0.219s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 11:04.450s > [INFO] Finished at: Wed Feb 26 19:34:31 FET 2014 > [INFO] Final Memory: 25M/297M > [INFO] > ------------------------------------------------------------------------ > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java > 4de36ca > > ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 2e114ef > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java > 6ce0022 > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXPropertyProviderTest.java > c2910db > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java > 0c793dc > ambari-server/src/test/resources/stacks/HDP/2.1.1/metainfo.xml PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/repoinfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks/HDP/2.1.1/role_command_order.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/configuration/placeholder.txt > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/package/placeholder.txt > PRE-CREATION > ambari-server/src/test/resources/storm_rest_api_jmx.json PRE-CREATION > > Diff: https://reviews.apache.org/r/18521/diff/ > > > Testing > ------- > > > Thanks, > > Arsen Babych > >
