> On April 15, 2014, 12:03 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java, > > lines 115-135 > > <https://reviews.apache.org/r/20327/diff/1/?file=556190#file556190line115> > > > > Not sure if these changes belong in the 151 upgrade catalog since 1.5.1 > > is basically out the door without this patch. If I understand correctly, > > there should be an upgrade catalog for the next version (1.6?) that > > includes these changes. > > Tom Beerbower wrote: > Maybe remove the upgrade catalog changes from this patch and open a Jira > to add them to the next upgrade catalog.
Agree with Tom, these changes should be in UpgradeCatalog160. Steps: - Override AbstractUpgradeCatalog and create UpgradeCatalog160, copy the lines of code here into the executeDDLUpdates. - Add UpgradeCatalog160.class to the CatalogBinder in the SchemaUpgradeHelper. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20327/#review40326 ----------------------------------------------------------- On April 14, 2014, 4:37 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20327/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 4:37 p.m.) > > > Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower. > > > Bugs: AMBARI-5462 > https://issues.apache.org/jira/browse/AMBARI-5462 > > > Repository: ambari > > > Description > ------- > > Allow users to specify host group scoped configuration in a blueprint. This > configuration is specified inline within host group definition. > A subsequent Jira will handle reusable host group scoped configuration that > is specified outside of the host group. > > Please see the Apache Jira for more information: > https://issues.apache.org/jira/browse/AMBARI-5462 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > ee3ff3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 8d26cfa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > e817473 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java > 7572930 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfiguration.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPK.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupEntity.java > fbc6ef4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog151.java > 3566e23 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 41e3127 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5418cac > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c2b0574 > ambari-server/src/main/resources/META-INF/persistence.xml 50f1fe0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > fbeecbd > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 922df27 > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityPKTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupConfigEntityTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20327/diff/ > > > Testing > ------- > > Functional Testing: > Used blueprint with host group scoped configuration to create a cluster and > ensure that config properties are set properly and visible in UI. > > Unit Tests: > - Added additional tests > - All tests pass > > Tests run: 1533, Failures: 0, Errors: 0, Skipped: 9 > ... > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:47.035s > [INFO] Finished at: Mon Apr 14 11:33:55 EDT 2014 > [INFO] Final Memory: 30M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > John Speidel > >
