-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20730/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5580
    https://issues.apache.org/jira/browse/AMBARI-5580


Repository: ambari


Description
-------

Add Requests/operation_level property support and support of subproperties. 
Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed 
COMPONENT level (specified at 
https://docs.google.com/a/hortonworks.com/document/d/1IB-2NGpLC3pb25S0FBI6L8PKaE24SMFqiJJKQHw9h8Q/edit#)
 from the list of available values, because it seems to be identical to SERVICE 
level.

This is a preview version of patch.

Patch seems to work, but unit test fixing/coverage is not finished yet


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 9839313 
  ambari-agent/src/main/python/ambari_agent/security.py 9801dec 
  ambari-agent/src/test/python/ambari_agent/TestController.py daa7b82 
  ambari-agent/src/test/python/ambari_agent/TestSecurity.py d8955cf 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 
e209076 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 40e9abb 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 7452a7b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java
 3443b72 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java
 aefcb52 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
 37a404f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 89eaa40 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 de3db69 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java
 3b5afcd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
 23583b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 36def40 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java
 14f0d55 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
 e7098d2 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/State.java 835b751 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java
 fb4a87a 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0a7a432 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
cbf8579 
  ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2 
  ambari-server/src/main/resources/properties.json f92d238 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive.py
 42a8610 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
 5ad1e77 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 ff3f08a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java
 5fc66a6 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
 062338b 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
f5148ff 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py d2a0390 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 111d8b3 
  ambari-web/app/assets/test/tests.js 1ba5922 
  ambari-web/app/controllers/main/host/details.js 4dea285 
  ambari-web/app/controllers/main/jobs/hive_job_details_controller.js 1e2df7e 
  ambari-web/app/controllers/wizard/step9_controller.js 8494a87 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
6222a88 
  ambari-web/app/router.js 73045d3 
  ambari-web/app/routes/installer.js deffe56 
  ambari-web/app/routes/main.js 9e00962 
  ambari-web/app/templates/wizard/step9.hbs 307609e 
  ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs  
  ambari-web/app/templates/wizard/step9/step9_install_host_popup.hbs  
  ambari-web/app/views.js 6555313 
  ambari-web/app/views/main/service/info/metrics/flume/flume_metric_graphs.js 
1ebfb60 
  ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js dd05b59 
  ambari-web/app/views/wizard/step9_view.js ec64530 
  ambari-web/test/installer/step9_test.js 2469828 
  ambari-web/test/views/wizard/step9/hostLogPopupBody_view_test.js 918d3d9 
  ambari-web/test/views/wizard/step9_view_test.js 733c3f9 

Diff: https://reviews.apache.org/r/20730/diff/


Testing
-------

Patch seems to work, but unit test fixing/coverage is not finished yet


Thanks,

Dmitro Lisnichenko

Reply via email to