----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20835/#review41711 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On April 29, 2014, 12:07 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20835/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 12:07 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-5611 > https://issues.apache.org/jira/browse/AMBARI-5611 > > > Repository: ambari > > > Description > ------- > > If YARN is not selected for installation, "start all services" phase fails > with > > > > > Fail: Configuration parameter 'jobhistory_heapsize' was not found in > configurations dictionary! > > > I think, jobhistory_heapsize parameter is used at mapred-env.sh template, that > is filled out when executing shared_initialization.py > Probably moving population of mapred-env.sh template into YARN service scripts > would be the best solution. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > a8500c0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > 2a7ac77 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/mapred-env.sh.j2 > 7570fd9 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py > ca204f6 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py > 0ae7f52 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/templates/mapred-env.sh.j2 > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > c831761 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > 850fcb6 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 51e6602 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > ebf7ba9 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 33f6c7f > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > 5a15689 > ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py > 1848899 > > Diff: https://reviews.apache.org/r/20835/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Onischuk > >
