-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20904/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-5640
    https://issues.apache.org/jira/browse/AMBARI-5640


Repository: ambari


Description
-------

Make sure that HISTORYSERVER metrics are available and names are consistent 
with existing metric names for other services.

Note : we have a lot of inconsistencies between metric names (underscrore, 
camel case, etc).  We can't fix this in API v1, but for new services we should 
make sure that the names are consistent with other services (i.e. we should be 
consistently inconsistent).  For example, in all existing services we have a 
metric named RpcQueueTime_avg_time.  We shouldn't call it RpcQueueTimeAvgTime 
in HISTORYSERVER.


Diffs
-----

  contrib/ambari-scom/ambari-scom-server/src/main/resources/jmx_properties.json 
2561483 

Diff: https://reviews.apache.org/r/20904/diff/


Testing
-------

All existing unit tests pass ...

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari SCOM Project ............................... SUCCESS [7.164s]
[INFO] Ambari SCOM Server ................................ SUCCESS [34.509s]
[INFO] Ambari SCOM Metrics Sink .......................... SUCCESS [6.947s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.933s
[INFO] Finished at: Wed Apr 30 15:00:28 EDT 2014
[INFO] Final Memory: 25M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower

Reply via email to