----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20948/#review41992 -----------------------------------------------------------
We need to make sure that all files match the coding conventions for Ambari ... https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari. Also, make sure that all files have appropriate Apache header. - Tom Beerbower On May 1, 2014, 1:52 p.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20948/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 1:52 p.m.) > > > Review request for Ambari, Tom Beerbower and Yusaku Sako. > > > Bugs: AMBARI-5617 > https://issues.apache.org/jira/browse/AMBARI-5617 > > > Repository: ambari > > > Description > ------- > > The code submission provides the implementation for a new Ambari View for > File Browsing called Files; allowing for browsing and file manipulation of > HDFS. > > > Diffs > ----- > > contrib/views/files/pom.xml PRE-CREATION > contrib/views/files/src/assembly/assembly.xml PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileBrowserService.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java > PRE-CREATION > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java > PRE-CREATION > contrib/views/files/src/main/resources/ui/.gitignore PRE-CREATION > contrib/views/files/src/main/resources/ui/app/adapter.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/app.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/fonts/FontAwesome.otf > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.eot > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.svg > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.ttf > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/fontawesome-webfont.woff > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/assets/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/assets/index.html > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/components/contextMenu.js > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/components/uploader.js > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/controllers/file.js > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/controllers/files.js > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/initialize.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/models/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/router.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/routes/error.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/routes/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/styles/application.less > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/application.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/error.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/files.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/index.hbs > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/templates/util/contextMenu.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/deleteBulk.hbs > PRE-CREATION > > contrib/views/files/src/main/resources/ui/app/templates/util/deletePopover.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/util/uploader.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/views/file.js PRE-CREATION > contrib/views/files/src/main/resources/ui/bin PRE-CREATION > contrib/views/files/src/main/resources/ui/bower.json PRE-CREATION > contrib/views/files/src/main/resources/ui/config.coffee PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/collection/collection.js.hbs > PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/collection/generator.json > PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/controller/controller.js.hbs > PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/controller/generator.json > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/model/generator.json > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/model/model.js.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/route/generator.json > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/route/route.js.hbs > PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/template/generator.json > PRE-CREATION > > contrib/views/files/src/main/resources/ui/generators/template/template.hbs.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/view/generator.json > PRE-CREATION > contrib/views/files/src/main/resources/ui/generators/view/view.js.hbs > PRE-CREATION > contrib/views/files/src/main/resources/ui/package.json PRE-CREATION > contrib/views/files/src/main/resources/ui/test/spec.coffee PRE-CREATION > contrib/views/files/src/main/resources/view.xml PRE-CREATION > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > PRE-CREATION > contrib/views/pom.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/20948/diff/ > > > Testing > ------- > > The code submission includes unit tests which all execute successfully. > > > Thanks, > > Erik Bergenholtz > >
