----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20730/#review42533 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On May 8, 2014, 7:56 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20730/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 7:56 p.m.) > > > Review request for Ambari, Nate Cole, Sumit Mohanty, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-5580 > https://issues.apache.org/jira/browse/AMBARI-5580 > > > Repository: ambari > > > Description > ------- > > Add Requests/operation_level property support and support of subproperties. > Possible "level" values are CLUSTER|SERVICE|HOST|HOST_COMPONENT. I've removed > COMPONENT level from the list of available values, because it seems to be > identical to SERVICE level. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > e209076 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 40e9abb > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 7452a7b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java > 3443b72 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/RequestBodyParser.java > aefcb52 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java > 37a404f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 89eaa40 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 6c88429 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExecuteActionRequest.java > 3b5afcd > > ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java > 23583b5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 36def40 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterStateEntity.java > 14f0d55 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > e7098d2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > d04dc26 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java > c86c3ed > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java > PRE-CREATION > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql bac1615 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 2b7f4d5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f12299f > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > cbf8579 > ambari-server/src/main/resources/META-INF/persistence.xml 36cafe2 > ambari-server/src/main/resources/properties.json f92d238 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 5ad1e77 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 2122a8b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > c0ad8ce > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/20730/diff/ > > > Testing > ------- > > I've performed manual testing in various scenarios (Mysql/Oracle DB). I've > also tried to check upgrade from 1.5.x, but it is broken in trunk as of now > (created a jira for that). > Result of unit test run attached. > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 34 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [2.200s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.312s] > [INFO] Ambari Web ........................................ SUCCESS [6.233s] > [INFO] Ambari Views ...................................... SUCCESS [1.822s] > [INFO] Ambari Server ..................................... SUCCESS > [12:57.429s] > [INFO] Ambari Agent ...................................... SUCCESS [5.038s] > [INFO] Ambari Client ..................................... SUCCESS [0.360s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:13.873s > [INFO] Finished at: Mon Apr 28 23:34:38 FET 2014 > [INFO] Final Memory: 31M/360M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
