----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21636/#review43531 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On May 19, 2014, 4:49 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21636/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 4:49 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar. > > > Bugs: AMBARI-5768 > https://issues.apache.org/jira/browse/AMBARI-5768 > > > Repository: ambari > > > Description > ------- > > Create a different glocal for hive heapsize -> hive_heapsize for hive-env.sh. > > https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=blob_plain;f=ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2;hb=HEAD > > Uses: > > {code} > export HADOOP_HEAPSIZE="{{hadoop_heapsize}}" > export HADOOP_CLIENT_OPTS="-Xmx${HADOOP_HEAPSIZE}m $HADOOP_CLIENT_OPTS" > {code} > > We should have a different global/parameter for this -> hive_heapsize in Hive > service page. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml > 5e4eb0e > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py > 1f21780 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/templates/hive-env.sh.j2 > b2da231 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml > 1bee2b9 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py > 96b0e45 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2 > 4e93443 > ambari-web/app/data/HDP2/global_properties.js 0922c1e > ambari-web/app/data/global_properties.js 4d33a8b > > Diff: https://reviews.apache.org/r/21636/diff/ > > > Testing > ------- > > > Thanks, > > Vitalyi Brodetskyi > >