----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21795/#review43709 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On May 21, 2014, 9:11 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21795/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 9:11 p.m.) > > > Review request for Ambari, Mahadev Konar, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-5799 > https://issues.apache.org/jira/browse/AMBARI-5799 > > > Repository: ambari > > > Description > ------- > > Use cases: > > Ability to filter by hostname and IP address, CPU, RAM, Load Avg. Regex > would be ideal as that's what the UI supports today. > Ability to sort asc/desc by hostname and IP address, CPU, RAM, Disk > Usage, Load Avg > > Proposed changes: > > New operator: <propertyId>.filter(expression) > New query parameter: > &sortBy=<propertyId>.<ASC/DESC>,<propertyId>.<ASC/DESC> > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java > d5717a6 > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java > 4ab75aa > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/FilterOperator.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/Operator.java > b3ced7a > > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/RelationalOperatorFactory.java > 4004ec3 > ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java > b1dfa3d > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > 0dda747 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java > 71c6f68 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/Request.java > bb53cf6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java > f49c890 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PageRequestImpl.java > 693d746 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SortRequestImpl.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/ComparisonPredicate.java > 345b906 > > ambari-server/src/main/java/org/apache/ambari/server/controller/predicate/FilterPredicate.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ClusterController.java > f6f94ff > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/PageRequest.java > dd97829 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SortRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/SortRequestProperty.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java > 782e128 > > ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java > a37114e > > ambari-server/src/test/java/org/apache/ambari/server/api/predicate/operators/FilterOperatorTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java > 335f101 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PageRequestImplTest.java > 95f0866 > > ambari-server/src/test/java/org/apache/ambari/server/controller/predicate/FilterPredicateTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21795/diff/ > > > Testing > ------- > > > Tests run: 1616, Failures: 0, Errors: 0, Skipped: 12 > > > Thanks, > > Sid Wagle > >
