-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21986/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sid Wagle.
Bugs: AMBARI-5914
https://issues.apache.org/jira/browse/AMBARI-5914
Repository: ambari
Description
-------
Server-side of a View should be able to “communicate” with other views. In this
context, ”communication” is the ability to fire events and listen for events.
The views framework should provide the interfaces for eventing, and the
framework itself might fire events too.
We also need to provide information about what other view instances are
available to a given user. I think we should get this from view context.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
84724c8
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
7b29098
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
1f936e7
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
c81bb5f
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
17d2619
ambari-server/src/main/java/org/apache/ambari/server/view/events/EventImpl.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
5754680
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
42dd7be
ambari-server/src/test/java/org/apache/ambari/server/view/events/EventImplTest.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/View.java PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 898e8f5
ambari-views/src/main/java/org/apache/ambari/view/ViewController.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/events/Event.java
PRE-CREATION
ambari-views/src/main/java/org/apache/ambari/view/events/Listener.java
PRE-CREATION
Diff: https://reviews.apache.org/r/21986/diff/
Testing
-------
New unit tests added. All existing tests pass ...
Results :
Tests run: 1631, Failures: 0, Errors: 0, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:19.185s
[INFO] Finished at: Wed May 28 15:34:47 EDT 2014
[INFO] Final Memory: 36M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
