----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21982/#review44257 -----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/HostInfo.py <https://reviews.apache.org/r/21982/#comment78603> let's remove useless comments ambari-agent/src/main/python/ambari_agent/HostInfo.py <https://reviews.apache.org/r/21982/#comment78605> why we don't use consts here? ambari-common/src/main/python/common_functions/os_check.py <https://reviews.apache.org/r/21982/#comment78604> Will we move this to json in feature? we should remove duplicating here. - Andrew Onischuk On May 28, 2014, 4:32 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21982/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 4:32 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-5911 > https://issues.apache.org/jira/browse/AMBARI-5911 > > > Repository: ambari > > > Description > ------- > > OS constants are defined in several places like HostInfo.py in agent, > utils.py in server. Definition of constants should be moved to os_check.py to > avoid possibly difference between constants in HostInfo.py and utils.py. > HostInfo.py > OS_UBUNTU_DEBIAN = 'debian' > OS_UBUNTU = 'ubuntu' > OS_FEDORA = 'fedora' > OS_OPENSUSE = 'opensuse' > OS_SUSE = 'suse' > OS_SUSE_ENTERPRISE = 'sles' > utils.py > OS_UBUNTU = 'ubuntu' > OS_FEDORA = 'fedora' > OS_OPENSUSE = 'opensuse' > OS_SUSE = 'suse' > OS_SUSE_ENTERPRISE = 'sles' > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 1e74dea > ambari-common/src/main/python/common_functions/__init__.py 50baaba > ambari-common/src/main/python/common_functions/os_check.py 79aaa75 > ambari-server/src/main/python/ambari-server.py 81dadbd > ambari-server/src/main/python/ambari_server/utils.py c132f50 > ambari-server/src/main/python/bootstrap.py 650751f > ambari-server/src/test/python/TestOSCheck.py f420095 > > Diff: https://reviews.apache.org/r/21982/diff/ > > > Testing > ------- > > > Thanks, > > Dmytro Sen > >
