----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22153/#review44525 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment78938> can just use params.hive_server_host and int(params.hive_server_port) as a shortcut. ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment78939> Logging methods should be available. ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment78944> I don't think this should be done, as it will not generate any backtrace. Should be Fail()'ed instead and let the Script base class be the one to handle exit codes. Augment test case. ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py <https://reviews.apache.org/r/22153/#comment78941> Don't have to go crazy on the Why. A simple "# wait for server to come up" will suffice. - Nate Cole On June 2, 2014, 2:37 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22153/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 2:37 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-5800 > https://issues.apache.org/jira/browse/AMBARI-5800 > > > Repository: ambari > > > Description > ------- > > The Hive server start check only looks for a PID when returning a successful > starting condition. Although the Hive service check depends on the server > starting, the server might not be up and running even though the PID exists. > > This changes the Hive start scripts to ensure they do not return a success > until the server because active and the connection port is open. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py > 568f6ec > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py > 596eec9 > ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 6cd9f52 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py cec393a > > Diff: https://reviews.apache.org/r/22153/diff/ > > > Testing > ------- > > Existing tests patched, new tests added to cover timeout period. > > ---------------------------------------------------------------------- > Total run:562 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > >
