----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22216/#review44662 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On June 3, 2014, 4:17 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22216/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 4:17 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-6014 > https://issues.apache.org/jira/browse/AMBARI-6014 > > > Repository: ambari > > > Description > ------- > > NAGIOS_* macros are required by our scripts in order to allow maintenance > model exit code alterations. Also, there was an error in the scripts which > would always cause the if-statement to execute, regardless of ignore.dat > contents. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh > 600cc5c > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/nagios.cfg.j2 > c778b2e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh > d198014 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/nagios.cfg.j2 > c778b2e > > Diff: https://reviews.apache.org/r/22216/diff/ > > > Testing > ------- > > Install of Nagios with verification that the script entered the correct > if/else structure and matched on the triple-grep. > > Also: > > ---------------------------------------------------------------------- > Total run:563 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > >
