[ 
https://issues.apache.org/jira/browse/AMBARI-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017370#comment-14017370
 ] 

Yusaku Sako commented on AMBARI-5980:
-------------------------------------

[~xiwang0309]
1. Please convert the code from making a synchronous AJAX call to asynchronous 
(we should not be using "async: false").
2. self.set('javaHome', property.split('"')[3]); <- This code is mysterious and 
also possibly error prone.  Why 3?  What's the expected API response?  What if 
after splitting, the length of the array is less than 4?  We should document 
the actual expected response from the server (ideally, we should put the mock 
file as we do for many other AJAX calls) 



> Usability: add JDK check in Host Checks UI
> ------------------------------------------
>
>                 Key: AMBARI-5980
>                 URL: https://issues.apache.org/jira/browse/AMBARI-5980
>             Project: Ambari
>          Issue Type: Task
>          Components: client
>    Affects Versions: 1.6.1
>            Reporter: Xi Wang
>            Assignee: Xi Wang
>             Fix For: 1.6.1
>
>         Attachments: AMBARI-5980.patch, AMBARI-5980.patch, AMBARI-5980.patch
>
>
> We need to expand Host Checks to include JDK check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to