> On June 11, 2014, 8:48 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java, > > line 741 > > <https://reviews.apache.org/r/22473/diff/1/?file=607594#file607594line741> > > > > Oozie has a similar New/Existing scenario, but that "New" is a Derby DB > > not a separate client to install. Can you verify if that case is covered > > or needs a line like this?
Since oozie uses a Derby DB by default, there is no host information in the default URL so there is no need to do topology fix-up of the oozie URL. If a user overrides the default they will be providing the new URL so this isn't necessary for Oozie. > On June 11, 2014, 8:48 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java, > > lines 863-864 > > <https://reviews.apache.org/r/22473/diff/1/?file=607595#file607595line863> > > > > See Oozie comment Thanks for the observant comment. See oozie response. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22473/#review45421 ----------------------------------------------------------- On June 11, 2014, 8:22 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22473/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 8:22 p.m.) > > > Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower. > > > Bugs: AMBARI-6041 > https://issues.apache.org/jira/browse/AMBARI-6041 > > > Repository: ambari > > > Description > ------- > > When deploying a cluster via a blueprint where the MYSQL_SERVER component is > not included in the topology but instead already exists, a 400 response is > returned to the user even if the user properly configured the necessary > configurations for an existing server. > { "status" : 400, "message" : "Unable to update configuration properties with > topology information. Component 'MYSQL_SERVER' is not mapped to any host > group or is mapped to multiple groups." } > This occurs when deploying the cluster when the configurations are updated > with topology related information. For components that may be external, we > need to check if the user updated the default hostname or port in the > corresponding configuration and if they have, don't do any topology update on > the property. > > *Note: This patch doesn't include any refactoring which is badly needed in > the blueprint processing code due to code freeze constraints. This work will > be done immediately after Ambari 1.6.1 branches. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java > 3f5a7c4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 054bd98 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/metainfo.xml > 36338ff > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml > 636ecd3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > 6d94183 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 913abac > > Diff: https://reviews.apache.org/r/22473/diff/ > > > Testing > ------- > > Functional Tests: > Created new cluster with external hive database > Created new cluster with managed MYSQL_SERVER as hive database > > Unit tests: > New unit tests > All unit tests pass > > Results : > > Tests run: 1661, Failures: 0, Errors: 0, Skipped: 13 > > ... > > Total run:572 > Total errors:0 > Total failures:0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:29.864s > [INFO] Finished at: Wed Jun 11 16:06:06 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > John Speidel > >
