----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22636/#review46053 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java <https://reviews.apache.org/r/22636/#comment81213> I think it's better to compare != MaintenanceState.OFF to support IMPLIED_* component states - Dmitro Lisnichenko On June 18, 2014, 10:02 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22636/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 10:02 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-6139 > https://issues.apache.org/jira/browse/AMBARI-6139 > > > Repository: ambari > > > Description > ------- > > API returns wrong data related to hosts health status > /api/v1/clusters/c1?fields=Clusters/health_report. All master components were > stopped for one node and few for other nodes, but healthy counter in server > response didn't changed. See screenshot. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 1352e32 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 49f69dc > > Diff: https://reviews.apache.org/r/22636/diff/ > > > Testing > ------- > > All unit tests passed > > > Thanks, > > Dmytro Sen > >
