----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22769/#review46202 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On June 19, 2014, 2:02 a.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22769/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 2:02 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-6201 > https://issues.apache.org/jira/browse/AMBARI-6201 > > > Repository: ambari > > > Description > ------- > > Fix sub-resource names for /stacks api. > Currently both /stacks and /stacks2 use the same resource definitions and > resource managers. The /stacks2 api doesn't conform with the existing api > conventions. The stacks api will eventually replace the stacks2 api after > the UI and assorted python scripts change to use /stacks. Also, stacks is > the api which will be used by customers. Many of the changes in this change > request are temporary and can be reversed after stacks2 is removed. The > intent of this change is to fix the "public" stacks api to conform with the > remainder of the api. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java > 63b1ca7 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryResourceDefinition.java > 2aff429 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > ddad6bf > ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNode.java > 3f8abdd > > ambari-server/src/main/java/org/apache/ambari/server/api/util/TreeNodeImpl.java > 7c90715 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseServiceTest.java > ef1b21a > > ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java > f8c385f > > Diff: https://reviews.apache.org/r/22769/diff/ > > > Testing > ------- > > Functional Testing: > Tested all /stacks api calls > Tested all /stacks2 api calls > Created a cluster > > Unit Tests: > All tests pass > Updated existing unit tests > > Results : > > Tests run: 1677, Failures: 0, Errors: 0, Skipped: 13 > ... > > Total run:570 > Total errors:0 > Total failures:0 > ... > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:21.665s > [INFO] Finished at: Wed Jun 18 20:02:38 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > John Speidel > >
