-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22784/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-6209
https://issues.apache.org/jira/browse/AMBARI-6209
Repository: ambari
Description
-------
When registering a blueprint, topology validation is done by default.
If a user want's to register a blueprint and skip topology validation this can
be done by specifying a directive in the query string:
blueprints/b1?validate_topology=false
This isn't working, no 400 topology validation error is returned to the user
but the blueprint isn't created.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
1642264
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BlueprintResourceDefinition.java
7e81a8f
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
6a169b1
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
b516df9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
8c99f90
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BlueprintResourceDefinitionTest.java
a4531c3
ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
85dbf97
Diff: https://reviews.apache.org/r/22784/diff/
Testing
-------
Functional Testing:
- Tested created bp with invalid topology and validation disabled
- Tested created cluster
Unit Tests:
- New tests added
- All existing tests pass
Results :
Tests run: 1684, Failures: 0, Errors: 0, Skipped: 13
...
Total run:570
Total errors:0
Total failures:0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:15.712s
[INFO] Finished at: Thu Jun 19 16:22:38 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel
