> On June 30, 2014, 3:50 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java, > > lines 332-333 > > <https://reviews.apache.org/r/23170/diff/1/?file=620480#file620480line332> > > > > I don't understand why this variable is named > > subResourcePropertiesInpredicate. How does checking to see if the > > properties of the processedPredicate are supported by the resource provider > > tell you if there are sub-resource properties in the predicate? Can you > > explain? > > > > Also, the camel case is wrong. I think you wanted > > subResourcePropertiesInPredicate. > >
Renamed to unsupportedProperties > On June 30, 2014, 3:50 p.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java, > > line 334 > > <https://reviews.apache.org/r/23170/diff/1/?file=620480#file620480line334> > > > > So if I read this correctly, it should return true if there are > > sub-resource properties in the predicate OR if there are sub-resource > > predicate properties. What is the difference? Can you explain? In debugger I see that, "/metrics/cpu/*" is a part of processed predicate and "host_components/*/*" is not, but "host_components/*/*" is in subResourcePredicateProperties. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23170/#review46983 ----------------------------------------------------------- On July 1, 2014, 10:50 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23170/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 10:50 a.m.) > > > Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower. > > > Bugs: AMBARI-6317 > https://issues.apache.org/jira/browse/AMBARI-6317 > > > Repository: ambari > > > Description > ------- > > Selected filter on components on Hosts page to filter by 'Namenode'. No hosts > were selected. > All parent-resources have to be populated if there is sub-resource in > predicate. > > Before patch getPage() were called for hosts requests even if > host_components/../... in predicate > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > a607761 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java > ad453d9 > > Diff: https://reviews.apache.org/r/23170/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [2.157s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s] > [INFO] Ambari Web ........................................ SUCCESS [26.103s] > [INFO] Ambari Views ...................................... SUCCESS [1.794s] > [INFO] Ambari Server ..................................... SUCCESS > [14:59.062s] > [INFO] Ambari Agent ...................................... SUCCESS [4.913s] > [INFO] Ambari Client ..................................... SUCCESS [0.029s] > [INFO] Ambari Python Client .............................. SUCCESS [1.100s] > [INFO] Ambari Groovy Client .............................. SUCCESS [11.434s] > [INFO] Ambari Shell ...................................... SUCCESS [6.173s] > > > Thanks, > > Dmytro Sen > >
