----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23233/#review47204 -----------------------------------------------------------
+1 - Erin Boyd On July 2, 2014, 4:18 p.m., subin m wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23233/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 4:18 p.m.) > > > Review request for Ambari, Erin Boyd and Mahadev Konar. > > > Bugs: AMBARI-6176 > https://issues.apache.org/jira/browse/AMBARI-6176 > > > Repository: ambari > > > Description > ------- > > Refactor Ambari-shell module to as below > ambari-groovy-shell > ambari-python-shell > assemblies > pom.xml > > Support the following > 1)add a separate modules for groovy and python shell > 2)add python shell > 3)support creation of ambari-python-shell.rpm and ambari-groovy-shell.rpm > > > Diffs > ----- > > ambari-shell/ambari-groovy-shell/pom.xml PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/ElephantCommand.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/completion/Host.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/customization/AmbariBanner.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/customization/AmbariPrompt.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/model/AmbariContext.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/model/Focus.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/model/FocusType.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/model/Hints.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/main/java/org/apache/ambari/shell/support/TableRenderer.java > PRE-CREATION > ambari-shell/ambari-groovy-shell/src/main/resources/elephant.txt > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/model/AmbariContextTest.java > PRE-CREATION > > ambari-shell/ambari-groovy-shell/src/test/java/org/apache/ambari/shell/support/TableRendererTest.java > PRE-CREATION > ambari-shell/ambari-groovy-shell/src/test/resources/2columns PRE-CREATION > ambari-shell/ambari-groovy-shell/src/test/resources/3columns PRE-CREATION > ambari-shell/ambari-groovy-shell/src/test/resources/testBlueprint.json > PRE-CREATION > ambari-shell/ambari-python-shell/conf/unix/ambari-shell PRE-CREATION > ambari-shell/ambari-python-shell/conf/unix/ambari-shell.ini PRE-CREATION > ambari-shell/ambari-python-shell/pom.xml PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/control > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/postinst > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/postrm > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/posttrm > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/preinst > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/package/deb/control/prerm > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/__init__.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/ambari_shell.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/__init__.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/blueprint.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/connect_cluster.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/create_cluster.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/service.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/shell_config.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/plugins/show.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/__init__.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/displayutils.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/osutils.py > PRE-CREATION > > ambari-shell/ambari-python-shell/src/main/python/ambari_shell/utils/pluginutils.py > PRE-CREATION > ambari-shell/ambari-python-shell/src/main/python/setup.py PRE-CREATION > ambari-shell/ambari-python-shell/src/packages/tarball/all.xml PRE-CREATION > ambari-shell/assemblies/client.xml PRE-CREATION > ambari-shell/pom.xml a7e3400 > ambari-shell/src/main/java/org/apache/ambari/shell/AmbariShell.java e842620 > > ambari-shell/src/main/java/org/apache/ambari/shell/commands/BasicCommands.java > 9babe12 > > ambari-shell/src/main/java/org/apache/ambari/shell/commands/BlueprintCommands.java > 73000d0 > > ambari-shell/src/main/java/org/apache/ambari/shell/commands/ClusterCommands.java > dafdb85 > > ambari-shell/src/main/java/org/apache/ambari/shell/commands/ElephantCommand.java > a236054 > > ambari-shell/src/main/java/org/apache/ambari/shell/commands/HostCommands.java > dd3c775 > > ambari-shell/src/main/java/org/apache/ambari/shell/completion/Blueprint.java > 4eec7b1 > ambari-shell/src/main/java/org/apache/ambari/shell/completion/Host.java > f64e97b > > ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ConverterConfiguration.java > 049c52f > > ambari-shell/src/main/java/org/apache/ambari/shell/configuration/ShellConfiguration.java > 4c493b0 > > ambari-shell/src/main/java/org/apache/ambari/shell/converter/BlueprintConverter.java > 7984e7f > > ambari-shell/src/main/java/org/apache/ambari/shell/converter/HostConverter.java > 39aa6e9 > > ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariBanner.java > f97ef59 > > ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariHistory.java > c23fc9a > > ambari-shell/src/main/java/org/apache/ambari/shell/customization/AmbariPrompt.java > b91e76e > ambari-shell/src/main/java/org/apache/ambari/shell/flash/AbstractFlash.java > 58abb75 > ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashService.java > 78977a6 > ambari-shell/src/main/java/org/apache/ambari/shell/flash/FlashType.java > 754a269 > > ambari-shell/src/main/java/org/apache/ambari/shell/flash/InstallProgress.java > 69164ea > ambari-shell/src/main/java/org/apache/ambari/shell/model/AmbariContext.java > af45dd6 > ambari-shell/src/main/java/org/apache/ambari/shell/model/Focus.java b637c87 > ambari-shell/src/main/java/org/apache/ambari/shell/model/FocusType.java > 121f7b4 > ambari-shell/src/main/java/org/apache/ambari/shell/model/Hints.java 990c832 > > ambari-shell/src/main/java/org/apache/ambari/shell/support/TableRenderer.java > 3e5af1f > ambari-shell/src/main/resources/elephant.txt f51e284 > > ambari-shell/src/test/java/org/apache/ambari/shell/commands/BlueprintCommandsTest.java > 3c9277c > > ambari-shell/src/test/java/org/apache/ambari/shell/commands/ClusterCommandsTest.java > 777d05d > > ambari-shell/src/test/java/org/apache/ambari/shell/commands/HostCommandsTest.java > 6ca6d4d > > ambari-shell/src/test/java/org/apache/ambari/shell/customization/AmbariPromptTest.java > ba90d00 > > ambari-shell/src/test/java/org/apache/ambari/shell/model/AmbariContextTest.java > ca9e919 > > ambari-shell/src/test/java/org/apache/ambari/shell/support/TableRendererTest.java > e576390 > ambari-shell/src/test/resources/2columns 190771b > ambari-shell/src/test/resources/3columns 127a414 > ambari-shell/src/test/resources/testBlueprint.json 971c46d > > Diff: https://reviews.apache.org/r/23233/diff/ > > > Testing > ------- > > ======================= > [WARNING] + exit 0 > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Python Shell ............................... SUCCESS [35.517s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [34.072s] > [INFO] Ambari Shell ...................................... SUCCESS [29.932s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:40.309s > [INFO] Finished at: Wed Jul 02 19:42:20 IST 2014 > [INFO] Final Memory: 33M/682M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > subin m > >
