----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23809/#review48361 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On July 22, 2014, 9:36 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23809/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 9:36 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-6561 > https://issues.apache.org/jira/browse/AMBARI-6561 > > > Repository: ambari > > > Description > ------- > > Add simple date restrictions to DAOs > Manually define JPA table sequence generators > > Database upgrade code will come in a later JIRA (already created) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java > f9f1f45 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java > da36c0c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java > a88d1ac > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 6533340 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ce64ae2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java > 227931e > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > 684d46c > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8875de7 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > dafda33 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > f2adcaa > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java > dfda132 > > Diff: https://reviews.apache.org/r/23809/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:41.654s > [INFO] Finished at: Tue Jul 22 09:36:31 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
