> On July 23, 2014, 4:33 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java, > > line 29 > > <https://reviews.apache.org/r/17668/diff/2/?file=640607#file640607line29> > > > > Expand imports before pushing, even if there's a +1 (the code is ok).
Done - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17668/#review48527 ----------------------------------------------------------- On July 23, 2014, 4:48 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17668/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 4:48 p.m.) > > > Review request for Ambari, Nate Cole and Sumit Mohanty. > > > Bugs: AMBARI-4513 > https://issues.apache.org/jira/browse/AMBARI-4513 > > > Repository: ambari > > > Description > ------- > > The expected behavior is Ambari need to start ZooKeeper as an HDFS service > dependency if the users did not start ZooKeeper services prior to starting > HDFS. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > d1e85df > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > dd99d87 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 21dcdc8 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > ea0d7ee > ambari-server/src/main/resources/properties.json 4d5407c > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > e51cea3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > b46736d > > ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java > db3fb91 > > Diff: https://reviews.apache.org/r/17668/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [1.802s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.319s] > [INFO] Ambari Web ........................................ SUCCESS [23.602s] > [INFO] Ambari Views ...................................... SUCCESS [1.886s] > [INFO] Ambari Admin View ................................. SUCCESS [0.101s] > [INFO] Ambari Server ..................................... SUCCESS > [14:48.170s] > [INFO] Ambari Agent ...................................... SUCCESS [3.118s] > [INFO] Ambari Client ..................................... SUCCESS [0.032s] > [INFO] Ambari Python Client .............................. SUCCESS [0.250s] > [INFO] Ambari Groovy Client .............................. SUCCESS [7.730s] > [INFO] Ambari Shell ...................................... SUCCESS [0.030s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.046s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [4.148s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > > > Thanks, > > Dmytro Sen > >
