----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24105/#review49121 -----------------------------------------------------------
Ship it! +1 ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java <https://reviews.apache.org/r/24105/#comment85961> Minor typo ... Encapsulates - Tom Beerbower On July 30, 2014, 3:13 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24105/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 3:13 p.m.) > > > Review request for Ambari, Dmytro Sen and Tom Beerbower. > > > Bugs: AMBARI-6673 > https://issues.apache.org/jira/browse/AMBARI-6673 > > > Repository: ambari > > > Description > ------- > > Ambari-server API should expose some way to cancel running tasks. For > example, PUT request may change state of a task or of an entire request to > ABORTED (and issue appropriate command(s) to the agent). > Current jira provides only mock implementation (for UI development) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 4bb9d1d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 6e35071 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java > 9483254 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > c7eecec > ambari-server/src/main/resources/properties.json 170fa4b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > 5c0d538 > > Diff: https://reviews.apache.org/r/24105/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [2.388s] > [INFO] Ambari Server ..................................... SUCCESS > [16:06.301s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:09.369s > [INFO] Finished at: Wed Jul 30 18:01:04 FET 2014 > [INFO] Final Memory: 25M/251M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
