----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24156/#review49249 -----------------------------------------------------------
Ship it! Minor comment about docs. The patch looks good to me. Also, nice cleanup! ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java <https://reviews.apache.org/r/24156/#comment86141> Doc here? ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java <https://reviews.apache.org/r/24156/#comment86140> Doc here? ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java <https://reviews.apache.org/r/24156/#comment86139> I think that we are supposed to doc all public methods, even if the usage is obvious. Up to you but maybe at least include the @param and @return tags. I know that we are not consistent with this and most of the rest of the class is missing docs. - Tom Beerbower On July 31, 2014, 4:17 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24156/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 4:17 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-6698 > https://issues.apache.org/jira/browse/AMBARI-6698 > > > Repository: ambari > > > Description > ------- > > The web client needs the following information made available on the exposed > stack definition endpoint: > > - whether a service supports service checks (via present of service-level > command script in metainfo.xml) > - the custom commands for a service (currently none) > - the custom commands for a component (from metainfo.xml) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7f53ded > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > fe2c0d6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > df91239 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java > 86d0455 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 21546e4 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > feec350 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > ee5ab44 > ambari-server/src/main/resources/properties.json 6397ecc > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 8c92ba3 > > Diff: https://reviews.apache.org/r/24156/diff/ > > > Testing > ------- > > Results : > > Tests run: 1846, Failures: 0, Errors: 0, Skipped: 13 > > > Thanks, > > Jonathan Hurley > >
